Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): only inline svg if imported via react #860

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Feb 16, 2022

Closes #854

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 365.69 KB (0%) 7.4 s (0%) 520 ms (+46.32% 🔺) 7.9 s

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #860 (6507aa1) into main (9f0fda1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          81       81           
  Lines        2837     2837           
  Branches      544      544           
=======================================
  Hits         1902     1902           
  Misses        907      907           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0fda1...6507aa1. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 6507aa1

@petethepig petethepig merged commit 2f3bdf0 into main Feb 16, 2022
@petethepig petethepig deleted the fix/logo-is-missing branch February 16, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logo is missing after #851
3 participants