fix(pprof): calculate sample rate based on the profile units #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
kolesnikovae
force-pushed
the
fix/pprof-custom-sample-rate
branch
from
8325dcc
to
f47c89a
Compare
Codecov Report
@@ Coverage Diff @@
## main #992 +/- ##
==========================================
+ Coverage 70.06% 70.09% +0.04%
==========================================
Files 84 84
Lines 2932 2935 +3
Branches 708 711 +3
==========================================
+ Hits 2054 2057 +3
Misses 875 875
Partials 3 3
Continue to review full report at Codecov.
|
# Conflicts: # pkg/convert/pprof/pprof_test.go # pkg/convert/pprof/writer.go # pkg/scrape/scrape.go # pkg/server/ingest.go # scripts/pprof-view/main.go
|
/create-server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out that our assumptions regarding pprof implementations are invalid: in particular,
pprof-nodejspackage uses microseconds as the sample period unit (in opposite to Go's nanoseconds).The PR:
/cc @shaleynikov