Fix issue #154: Add ability to change sampling rate #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we need to make custom profiler
|
|
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 57.26% 57.12% -0.13%
==========================================
Files 73 73
Lines 2936 2957 +21
==========================================
+ Hits 1681 1689 +8
- Misses 1112 1122 +10
- Partials 143 146 +3
Continue to review full report at Codecov.
|
petethepig
changed the title
alonlong
changed the title
petethepig
reviewed
May 16, 2021
petethepig
reviewed
May 16, 2021
| var DefaultProfileTypes = []ProfileType{ProfileCPU, ProfileAllocObjects, ProfileAllocSpace, ProfileInuseObjects, ProfileInuseSpace} | ||
|
|
||
| type Config struct { | ||
| ApplicationName string // e.g backend.purchases | ||
| ServerAddress string // e.g http://pyroscope.services.internal:4040 | ||
| AuthToken string // specify this token when using pyroscope cloud | ||
| SampleRate uint32 |
There was a problem hiding this comment.
Suggested change
| SampleRate uint32 | |
| // SampleRate uint32 |
I think we should comment this out until we implement golang profiler support (#191)
…r defining the common const or variables; 3. make the spyname to a const variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the sample rate configured for python, ruby and go, but it doesn't take affect for go, because we use the the 'runtime profile' of golang, we need to find the way to build the customer profiler for go.