Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .Net support #200

Merged
merged 6 commits into from
May 21, 2021
Merged

Add .Net support #200

merged 6 commits into from
May 21, 2021

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented May 19, 2021

The change introduces support for .Net CPU time profiling.

dotnetspy uses Diagnostic IPC Protocol client to communicate to .Net runtime and gather trace events. It is important to note that only managed code is accounted. Refer to dotnetdiag package for implementation details.

Supported versions:

  • .Net 5.0
  • .Net Core 3.1

Examples:

  • web - a web app that listens on :5000/tcp and performs some calculations.
  • fast-slow - a single thread application similar to examples for other runtimes:

image

@CLAassistant
Copy link

CLAassistant commented May 19, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot requested a review from Rperry2174 May 19, 2021 16:30
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #200 (18b9cd8) into main (812ca3f) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   57.49%   57.29%   -0.19%     
==========================================
  Files          73       73              
  Lines        2938     2943       +5     
==========================================
- Hits         1689     1686       -3     
- Misses       1106     1112       +6     
- Partials      143      145       +2     
Impacted Files Coverage Δ
pkg/agent/session.go 63.94% <ø> (-3.27%) ⬇️
pkg/agent/spy/spy.go 5.00% <ø> (ø)
pkg/analytics/analytics.go 86.96% <100.00%> (+0.20%) ⬆️
pkg/convert/parser.go 62.80% <0.00%> (-3.06%) ⬇️
pkg/server/ingest.go 63.39% <0.00%> (-1.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812ca3f...18b9cd8. Read the comment docs.

@kolesnikovae kolesnikovae linked an issue May 19, 2021 that may be closed by this pull request
Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, merging

@petethepig petethepig merged commit 99f1149 into main May 21, 2021
@petethepig petethepig deleted the dotnetspy branch May 21, 2021 01:27
kolesnikovae added a commit that referenced this pull request May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .NET support
3 participants