Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the compile on linux system, like ubuntu and centos #202

Merged
merged 4 commits into from
May 24, 2021

Conversation

alonlong
Copy link
Contributor

the test is passed on ubuntu and centos, and the main dependent library is unwind:

  1. for ubuntu: sudo apt-get install libunwind libunwind-dev
  2. for centos: sudo dnf install libunwind libunwind-devel

@alonlong alonlong added the enhancement New feature or request label May 21, 2021
@alonlong alonlong requested a review from petethepig May 21, 2021 00:19
@github-actions github-actions bot requested a review from Rperry2174 May 21, 2021 00:19
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #202 (6799100) into main (bc5d5e7) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   57.21%   57.23%   +0.02%     
==========================================
  Files          73       73              
  Lines        2942     2943       +1     
==========================================
+ Hits         1683     1684       +1     
  Misses       1114     1114              
  Partials      145      145              
Impacted Files Coverage Δ
pkg/agent/session.go 63.94% <0.00%> (ø)
pkg/agent/spy/spy.go 5.00% <0.00%> (ø)
pkg/analytics/analytics.go 84.06% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5d5e7...6799100. Read the comment docs.

@Rperry2174 Rperry2174 added this to In Review in Pyroscope Public Roadmap May 21, 2021
pkg/agent/pyspy/pyspy.go Outdated Show resolved Hide resolved
pkg/agent/rbspy/rbspy.go Outdated Show resolved Hide resolved
@petethepig petethepig merged commit 5098f57 into main May 24, 2021
@petethepig petethepig deleted the feature/compile_on_linux branch May 24, 2021 21:57
@petethepig petethepig moved this from In Review to Done in Pyroscope Public Roadmap May 26, 2021
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Allows to override any config per component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants