-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes: #192 Use the specific config structure for each command #208
Closes: #192 Use the specific config structure for each command #208
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 57.36% 57.03% -0.32%
==========================================
Files 73 73
Lines 2943 2981 +38
==========================================
+ Hits 1688 1700 +12
- Misses 1110 1131 +21
- Partials 145 150 +5
Continue to review full report at Codecov.
|
639bd31
to
9ad208d
Compare
9ad208d
to
91ba7fe
Compare
cs *csock.CSock | ||
activeProfiles map[int]*agent.ProfileSession | ||
id id.ID | ||
u upstream.Upstream | ||
} | ||
|
||
func New(cfg *config.Config) *Agent { | ||
func New(cfg *config.Agent) *Agent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petethepig Seems that this is unused, is that possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we'll delete it soon
@@ -15,19 +15,19 @@ import ( | |||
) | |||
|
|||
type Agent struct { | |||
cfg *config.Config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petethepig
Do we want to keep the config.Config struct?
If my understanding is correct, the lifetime of all the config structs are withing the Start(cfg *config.Config)
function in cli.go, so maybe we don't need an extra container for all the configs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point, we might do that in the future
Sort Profiles by Labels (alphabetical) in Parquet
#192