Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support (agent) #212

Merged
merged 19 commits into from
Jun 7, 2021
Merged

Windows support (agent) #212

merged 19 commits into from
Jun 7, 2021

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented May 25, 2021

This PR is the first step toward full-fledged Windows support. With this change, pyroscope can be run on Windows in agent, exec and connect modes.

Limitations:

  • Minimal supported version: Windows 10 Build 17063.
  • Only gospy and dotnetspy can be used. In contrast to Linux/macOS, on Windows, dotnetspy accounts time spent in unmanaged code.

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #212 (b430e0e) into main (2cc5f0e) will decrease coverage by 0.63%.
The diff coverage is 39.24%.

❗ Current head b430e0e differs from pull request most recent head 985a599. Consider uploading reports for the commit 985a599 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   56.07%   55.45%   -0.62%     
==========================================
  Files          74       82       +8     
  Lines        3089     3214     +125     
==========================================
+ Hits         1732     1782      +50     
- Misses       1186     1252      +66     
- Partials      171      180       +9     
Impacted Files Coverage Δ
cmd/pyroscope/logging.go 66.67% <0.00%> (-33.33%) ⬇️
cmd/pyroscope/main.go 0.00% <0.00%> (ø)
cmd/pyroscope/main_unix.go 0.00% <0.00%> (ø)
pkg/agent/target/service.go 0.00% <0.00%> (ø)
pkg/agent/target/service_unix.go 0.00% <0.00%> (ø)
pkg/cli/agent_unix.go 0.00% <0.00%> (ø)
pkg/cli/server_unix.go 0.00% <0.00%> (ø)
pkg/cli/usage.go 10.26% <ø> (ø)
pkg/exec/cli_linux.go 13.34% <ø> (ø)
pkg/util/disk/usage_unix.go 60.00% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39670c...985a599. Read the comment docs.

@@ -1,3 +1,5 @@
// +build !windows
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FreeSpace on Linux/macOS relies on statfs bfree (free blocks in filesystem), consider use of bavail (free blocks available to unprivileged user).

@kolesnikovae kolesnikovae added enhancement New feature or request windows labels May 25, 2021
Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petethepig petethepig merged commit c1babda into main Jun 7, 2021
@petethepig petethepig deleted the windows-support branch June 7, 2021 23:40
@kolesnikovae kolesnikovae linked an issue Jun 15, 2021 that may be closed by this pull request
2 tasks
@Rperry2174 Rperry2174 moved this from Included in Next Release to Done in Pyroscope Public Roadmap Jul 15, 2021
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Use correct column name for sorting order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request windows
Development

Successfully merging this pull request may close these issues.

Windows support
2 participants