fix the issue #188: add the file name and code line #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petethepig
reviewed
May 25, 2021
pkg/exec/cli.go
Outdated
| @@ -28,7 +28,6 @@ import ( | |||
|
|
|||
| // used in tests | |||
| var disableMacOSChecks bool | |||
| var disableLinuxChecks bool | |||
I think this format makes the most sense because it's both * human-readable * machine-readable (this is RFC3339 with microseconds) * relatively popular * a-z sortable * less ambiguous when it comes to month/day vs day/month conventions * has good enough precision for our use-case but not too much
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 57.36% 56.90% -0.46%
==========================================
Files 73 73
Lines 2943 2988 +45
==========================================
+ Hits 1688 1700 +12
- Misses 1110 1137 +27
- Partials 145 151 +6
Continue to review full report at Codecov.
|
korniltsev
pushed a commit
that referenced
this pull request
Jul 18, 2023
Add createdBy metadata to point to fire and its version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the output format is like:
INFO[25-05-2021 23:05:56] cli/cli.go:415 starting HTTP server