Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/segment cache panic #222

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Hotfix/segment cache panic #222

merged 3 commits into from
Jun 2, 2021

Conversation

alonlong
Copy link
Contributor

  1. add the error handler for different cache
  2. solve the panic when root node is not ready for segment

@alonlong alonlong added bug Something isn't working backend Mostly go code labels May 28, 2021
@petethepig
Copy link
Member

There's one test that's failing. Could you fix it please? https://github.com/pyroscope-io/pyroscope/pull/222/checks?check_run_id=2694916899

Other than that it looks good I think.

@alonlong
Copy link
Contributor Author

done, please help to check

@alonlong alonlong changed the title Hoxfix/segment cache panic Hotfix/segment cache panic May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #222 (9fbf730) into main (63e622f) will decrease coverage by 0.83%.
The diff coverage is 45.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   56.97%   56.14%   -0.82%     
==========================================
  Files          73       73              
  Lines        2988     3039      +51     
==========================================
+ Hits         1702     1706       +4     
- Misses       1135     1165      +30     
- Partials      151      168      +17     
Impacted Files Coverage Δ
pkg/agent/profiler/profiler.go 0.00% <0.00%> (ø)
pkg/agent/selfprofile.go 0.00% <0.00%> (ø)
pkg/cli/cli.go 54.45% <0.00%> (-0.40%) ⬇️
pkg/storage/dict/serialize.go 61.37% <0.00%> (ø)
pkg/storage/dimension/serialization.go 0.00% <0.00%> (ø)
pkg/storage/segment/serialization.go 73.87% <0.00%> (-1.71%) ⬇️
pkg/storage/tree/serialize.go 70.09% <0.00%> (ø)
pkg/storage/storage.go 62.03% <51.29%> (-9.32%) ⬇️
pkg/agent/upstream/remote/remote.go 65.63% <62.50%> (+0.84%) ⬆️
pkg/exec/cli.go 39.78% <62.50%> (-0.65%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dac56...9fbf730. Read the comment docs.

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petethepig petethepig merged commit 81ba6c4 into main Jun 2, 2021
@petethepig petethepig deleted the hoxfix/segment_cache_panic branch June 2, 2021 03:16
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Ensure it always uses the fixed image from Grafana
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Mostly go code bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants