-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/segment cache panic #222
Conversation
alonlong
commented
May 28, 2021
- add the error handler for different cache
- solve the panic when root node is not ready for segment
…node is not ready for segment
There's one test that's failing. Could you fix it please? https://github.com/pyroscope-io/pyroscope/pull/222/checks?check_run_id=2694916899 Other than that it looks good I think. |
done, please help to check |
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 56.97% 56.14% -0.82%
==========================================
Files 73 73
Lines 2988 3039 +51
==========================================
+ Hits 1702 1706 +4
- Misses 1135 1165 +30
- Partials 151 168 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ensure it always uses the fixed image from Grafana