Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make phpspy use direct read from mem #239

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Conversation

AdrK
Copy link
Contributor

@AdrK AdrK commented Jun 15, 2021

Do not merge before:
grafana/phpspy#3

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #239 (1a6dc66) into main (af9a745) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   54.96%   54.85%   -0.11%     
==========================================
  Files          86       86              
  Lines        3583     3583              
==========================================
- Hits         1969     1965       -4     
- Misses       1410     1414       +4     
  Partials      204      204              
Impacted Files Coverage Δ
pkg/analytics/analytics.go 84.06% <0.00%> (-2.89%) ⬇️
pkg/agent/upstream/remote/remote.go 62.32% <0.00%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9a745...1a6dc66. Read the comment docs.

@AdrK AdrK requested a review from petethepig June 15, 2021 09:45
@petethepig petethepig marked this pull request as ready for review June 17, 2021 04:59
@github-actions github-actions bot requested a review from Rperry2174 June 17, 2021 05:00
@petethepig petethepig merged commit e8201ca into main Jun 17, 2021
@petethepig petethepig deleted the phpspy_direct_from_mem branch June 17, 2021 08:23
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Add unit tests for MergeProfilesStacktraces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants