Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore tags on dictionary lookup #245

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Ignore tags on dictionary lookup #245

merged 1 commit into from
Jun 21, 2021

Conversation

kolesnikovae
Copy link
Collaborator

No description provided.

@kolesnikovae kolesnikovae self-assigned this Jun 18, 2021
@kolesnikovae kolesnikovae added backend Mostly go code enhancement New feature or request performance If there's anything we have to be really good at it's this storage Low level storage matters labels Jun 18, 2021
@kolesnikovae kolesnikovae changed the title Ignore tags at dictionary lookup Ignore tags on dictionary lookup Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #245 (3fa65c5) into main (4a429df) will decrease coverage by 0.18%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   54.79%   54.62%   -0.17%     
==========================================
  Files          86       86              
  Lines        3581     3589       +8     
==========================================
- Hits         1962     1960       -2     
- Misses       1415     1425      +10     
  Partials      204      204
Impacted Files Coverage Δ
pkg/storage/storage.go 59.89% <34.79%> (-1.20%) ⬇️
pkg/storage/key.go 85.72% <100.00%> (-4.60%) ⬇️
pkg/agent/session.go 63.20% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a429df...3fa65c5. Read the comment docs.

@petethepig
Copy link
Member

Looks good.

@kolesnikovae kolesnikovae marked this pull request as ready for review June 21, 2021 16:37
@petethepig petethepig merged commit e756a20 into main Jun 21, 2021
@petethepig petethepig deleted the per-app-dict branch June 21, 2021 21:32
@kolesnikovae kolesnikovae mentioned this pull request Jul 29, 2021
Closed
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
@cyriltovena
Merge pull request #245 from grafana/fixes-stacktraces-symbols
4ec0680 
Fixes stacktraces symbolization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petethepig petethepig petethepig approved these changes

@Rperry2174 Rperry2174 Awaiting requested review from Rperry2174

Assignees

@kolesnikovae kolesnikovae

Labels
backend Mostly go code enhancement New feature or request performance If there's anything we have to be really good at it's this storage Low level storage matters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kolesnikovae @petethepig