Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: add support for dynamic tags #437

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

awwalker
Copy link
Contributor

@awwalker awwalker commented Oct 4, 2021

For #433

The issue mentions adding tests but I was a little unsure about the best way to add tests to the profiler because of the upstream instantiation. I added a couple of unit tests to the session which the profiler wraps instead but happy to revisit tests if y'all have some guidance on the best way to test the profiler

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2021

CLA assistant check
All committers have signed the CLA.

@awwalker awwalker marked this pull request as ready for review October 5, 2021 16:39
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #437 (1fea430) into main (bac1171) will increase coverage by 0.03%.
The diff coverage is 20.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   51.51%   51.53%   +0.03%     
==========================================
  Files         125      125              
  Lines        5683     5719      +36     
==========================================
+ Hits         2927     2947      +20     
- Misses       2472     2487      +15     
- Partials      284      285       +1     
Impacted Files Coverage Δ
pkg/agent/profiler/profiler.go 0.00% <0.00%> (ø)
pkg/agent/session.go 63.91% <62.50%> (+5.27%) ⬆️
pkg/agent/upstream/remote/remote.go 57.36% <0.00%> (-5.88%) ⬇️
pkg/exec/cli_unix.go 9.44% <0.00%> (-1.88%) ⬇️
pkg/exec/cli.go 46.48% <0.00%> (-0.70%) ⬇️
pkg/server/render.go 67.47% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac1171...1fea430. Read the comment docs.

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @awwalker !

@petethepig petethepig merged commit 4ab01ce into grafana:main Oct 5, 2021
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
…provider

feat(objstore): support Tencent COS object storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants