Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analytics): adds java to list of integrations we track #450

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

petethepig
Copy link
Member

This also adds controller_comparison and controller_diff parameters.

@petethepig petethepig added the backend Mostly go code label Oct 8, 2021
@pyroscopebot
Copy link
Collaborator

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 155.55 155.36 -0.18 (-0.12%) 5%
total items processed 133274.00 132867.00 -407.00 (-0.31%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against b4cdf67

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #450 (89a0851) into main (1d5868b) will increase coverage by 0.04%.
The diff coverage is 85.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   51.64%   51.67%   +0.04%     
==========================================
  Files         125      125              
  Lines        5719     5725       +6     
==========================================
+ Hits         2953     2958       +5     
  Misses       2479     2479              
- Partials      287      288       +1     
Impacted Files Coverage Δ
pkg/server/handler.go 18.13% <0.00%> (-0.34%) ⬇️
pkg/analytics/analytics.go 87.02% <100.00%> (+0.53%) ⬆️
pkg/server/render.go 67.47% <0.00%> (ø)
pkg/agent/upstream/remote/remote.go 66.18% <0.00%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7e83f...89a0851. Read the comment docs.

@petethepig petethepig merged commit 65358d9 into main Oct 8, 2021
@petethepig petethepig deleted the analytics-javaspy branch October 8, 2021 19:32
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Mostly go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants