Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup / tooltip issues #452

Merged
merged 16 commits into from
Oct 11, 2021
Merged

cleanup / tooltip issues #452

merged 16 commits into from
Oct 11, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 8, 2021

  • removed duplicated format functions
  • moved format.js -> format.ts
  • added tests to format.ts
  • refactor units ("samples" | "objects" | "bytes") into an enum
  • fix stale props issue with the tooltip (item number 2 from Fix tooltip issues #445)

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #452 (022f888) into main (2fd51d1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
- Coverage   51.64%   51.64%   -0.00%     
==========================================
  Files         125      125              
  Lines        5719     5725       +6     
==========================================
+ Hits         2953     2956       +3     
- Misses       2479     2481       +2     
- Partials      287      288       +1     
Impacted Files Coverage Δ
pkg/server/handler.go 18.13% <0.00%> (-0.34%) ⬇️
pkg/analytics/analytics.go 87.02% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd51d1...022f888. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Oct 8, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 155.94 155.87 -0.07 (-0.05%) 5%
total items processed 133143.00 132696.00 -447.00 (-0.34%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against d0e7ed3

@eh-am eh-am marked this pull request as draft October 8, 2021 20:07
@eh-am eh-am marked this pull request as ready for review October 8, 2021 21:00
@eh-am eh-am marked this pull request as draft October 8, 2021 21:12
@eh-am eh-am marked this pull request as ready for review October 8, 2021 21:24
@eh-am eh-am merged commit 9486ee0 into main Oct 11, 2021
@eh-am eh-am deleted the fix-tooltip-path-445 branch October 11, 2021 15:08
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Release helm chart v0.1.2 with Phlare version v0.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants