Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic context menu #460

Merged
merged 5 commits into from
Oct 13, 2021
Merged

feat: add basic context menu #460

merged 5 commits into from
Oct 13, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 11, 2021

  • Create basic context menu
  • Add that menu to the flamegraph (triggered via contexmenu event, ie right click)
  • Add a single item "Reset View"
  • integration tests
  • Unit tests

Also increased the BAR_HEIGHT to make it easier to click.

Peek 2021-10-12 12-18

We rely strictly on contextmenu event, which does not seem to work on IOS (https://webkit.org/b/213953)

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #460 (7b50187) into main (ec5b5fa) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   51.57%   51.61%   +0.04%     
==========================================
  Files         125      125              
  Lines        5734     5734              
==========================================
+ Hits         2957     2959       +2     
+ Misses       2488     2486       -2     
  Partials      289      289              
Impacted Files Coverage Δ
pkg/agent/upstream/remote/remote.go 66.18% <0.00%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5b5fa...7b50187. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Oct 11, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 156.55 156.52 -0.02 (-0.01%) 5%
total items processed 133144.00 133443.00 299.00 (0.22%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against cda1011

@eh-am eh-am marked this pull request as ready for review October 12, 2021 16:48
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think increasing the bar height is fine. This for a temporary time make languages with deep/high stacktraces a slightly worse experience. However, once we add the collapse feature I think this will be fixed.

@eh-am eh-am merged commit 3df5d9d into main Oct 13, 2021
@eh-am eh-am deleted the context-menu branch October 13, 2021 17:04
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants