Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate random app name in Cypress test #463

Merged
merged 5 commits into from
Oct 17, 2021
Merged

Generate random app name in Cypress test #463

merged 5 commits into from
Oct 17, 2021

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 12, 2021

Until we implement app deletion, we have to generate random app names to guarantee the application we are testing against is brand new.

Problem with using a uuid is that it generate apps with names starting with numbers, which even thought we allow it, it doesn't play well with promQL syntax highlight
image

Also update cypress to 8.6.0

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #463 (492a3bb) into main (02e3b1e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   51.57%   51.57%           
=======================================
  Files         125      125           
  Lines        5734     5734           
=======================================
  Hits         2957     2957           
  Misses       2488     2488           
  Partials      289      289           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e840a83...492a3bb. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Oct 12, 2021

Parameters

Details
Name Value
BENCH_RUN_FOR 10m
PYROBENCH_RAND_SEED 2306912
PYROBENCH_PROFILE_WIDTH 20
PYROBENCH_PROFILE_DEPTH 20
PYROBENCH_PROFILE_SYMBOL_LENGTH 30
PYROBENCH_APPS 20
PYROBENCH_CLIENTS 20
PYROBENCH_REQUESTS 10000

Result

main pr diff threshold
throughput 158.22 158.28 0.06 (0.04%) 5%
total items processed 132716.00 133115.00 399.00 (0.30%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope_main:4040"}

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Generated by 🚫 dangerJS against 0706c6b

Copy link
Member

@petethepig petethepig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petethepig petethepig merged commit bc427f2 into main Oct 17, 2021
@petethepig petethepig deleted the random-app-name branch October 17, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants