Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RustEmbed derive macro is susceptible to naming collisions #229

Closed
hwittenborn opened this issue Dec 26, 2023 · 2 comments · Fixed by #230
Closed

RustEmbed derive macro is susceptible to naming collisions #229

hwittenborn opened this issue Dec 26, 2023 · 2 comments · Fixed by #230
Labels
bug

Comments

@hwittenborn
Copy link
Contributor

I noticed that the RustEmbed derive macro is susceptible to collisions in item names used in the macro. I encountered this issue earlier today from the use of Box, which is being used as GTK4's Box in my crate.

I feel like the macro should be using absolute paths (::std::boxed::Box I think?) to avoid the issue.
@pyrossh
Copy link
Owner

pyrossh commented Dec 28, 2023

Yep. You're right. Interested in a a PR?

@hwittenborn
Copy link
Contributor Author

Sure thing @pyrossh! I'll go ahead and get one going.

@hwittenborn hwittenborn mentioned this issue Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix naming collisions in macros
3 participants
@pyrossh @AzureMarker @hwittenborn