[Pyrra v0.7.0] Missing changes in CRD?

[hsolberg]

Hi!

We noticed some strange things while testing the new version in our dev cluster. When applying the new CRD from the v0.7.0 tag (or master, both seems to be identical) this change seems to be missing:

pyrra/config/crd/bases/pyrra.dev_servicelevelobjectives.json

Lines 69 to 76 in 0dce672

	"absent": {
	"default": true,
	"type": "boolean"
	},
	"burnrates": {
	"default": true,
	"type": "boolean"
	},

pyrra/config/crd/bases/pyrra.dev_servicelevelobjectives.yaml

Lines 57 to 62 in 0dce672

	absent:
	default: true
	type: boolean
	burnrates:
	default: true
	type: boolean

Here's the CRD from main/master-branch:
https://github.com/pyrra-dev/pyrra/blob/main/examples/kubernetes/manifests/setup/pyrra-slo-CustomResourceDefinition.yaml#L50-L57

And the one tagged with v0.7.0:
https://github.com/pyrra-dev/pyrra/blob/v0.7.0/examples/kubernetes/manifests/setup/pyrra-slo-CustomResourceDefinition.yaml#L50-L57

Both seem to be missing the new option for disabling absent alerts and burnrates.

Current workaround is to use this CRD https://github.com/pyrra-dev/pyrra/blob/0dce67252ae42e59cde4500603a65fa49dfc5bc4/config/crd/bases/pyrra.dev_servicelevelobjectives.yaml

[metalmatze]

Oops. Thank you for reporting this.
Sorry for replying only now, due to organising PromCon the last days.

[hsolberg]

No worries, we used the CRD here as a workaround.
Seems the CRD is still missing the new options though, but the schema is updated.

[metalmatze]

The generated examples have been updated and are available on the release-0.7. As the examples/ is mostly documentation purposes I'll wait for another bit before releasing v0.7.2.