Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable reload URI #986

Open
keithherron opened this issue Nov 16, 2023 · 1 comment
Open

Customizable reload URI #986

keithherron opened this issue Nov 16, 2023 · 1 comment

Comments

@keithherron
Copy link

keithherron commented Nov 16, 2023

In my deployment I'm loading the Pyrra filesystem generated recording rules using Thanos rule. It is working well so far with the exception of the automatic reload.

Pyrra logs "failed to reload Prometheus" and a manual reload is necessary to pick up rules when changes are made to Pyrra.

It'd be nice to have the ability to configure Pyrra with a customizable URI for the reload action, in my case it would be http://localhost:17902/rule/-/reload (which makes use of web.(route|external)-prefix feature)

@metalmatze
Copy link
Member

Makes sense! We can add this via a flag on the filesystem component.

Funnily enough, I've used Pyrra with Thanos before, but it was using the Prometheus Operator to reload the configs, which is why I didn't encounter this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants