Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust compiler warning while building on windows #1103

Closed
tiainen opened this issue Sep 27, 2022 · 1 comment · Fixed by #1104
Closed

Rust compiler warning while building on windows #1103

tiainen opened this issue Sep 27, 2022 · 1 comment · Fixed by #1104
Assignees
@tiainen
Labels
bug Something isn't working triage This is a new issue that needs to be reviewed at our Sprint Planning

Comments

@tiainen
Copy link
Collaborator

tiainen commented Sep 27, 2022

When building the pyrsia source code on the Windows platform, the following warning is printed by the rust compiler:

warning: the following packages contain code that will be rejected by a future version of Rust: ntapi v0.3.7

Running cargo tree -i ntapi reveals that the package is included by a dependency on the crate sysinfo v0.26.1:

ntapi v0.3.7
└── sysinfo v0.26.1
    └── pyrsia v0.1.0 (pyrsia)
@tiainen tiainen added the bug Something isn't working label Sep 27, 2022
@tiainen tiainen self-assigned this Sep 27, 2022
@github-actions github-actions bot added the triage This is a new issue that needs to be reviewed at our Sprint Planning label Sep 27, 2022
@tiainen
Copy link
Collaborator Author

tiainen commented Sep 27, 2022

The issue has been fixed with MSxDOS/ntapi#12.

Upgrading to sysinfo v0.26.4 will also bring in ntapi v0.4.0 where this fix has been included. See https://github.com/GuillaumeGomez/sysinfo/blob/master/CHANGELOG.md#0264

@tiainen tiainen mentioned this issue Sep 27, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiainen tiainen

Labels
bug Something isn't working triage This is a new issue that needs to be reviewed at our Sprint Planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update sysinfo to v0.26.4 tiainen/pyrsia
1 participant
@tiainen