Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop treating ArtifactAlreadyExists as an error? #1322

Closed
ihcomega56 opened this issue Nov 23, 2022 · 1 comment · Fixed by #1605
Closed

Stop treating ArtifactAlreadyExists as an error? #1322

ihcomega56 opened this issue Nov 23, 2022 · 1 comment · Fixed by #1605
Assignees
@dasmanas
Labels
enhancement New feature or request
Milestone
0.2.5

Comments

@ihcomega56
Copy link
Contributor

Suggestion details

pyrsia/src/docker/error_util.rs

Line 62 in 20c2385

BuildError::ArtifactAlreadyExists(_) => RegistryError {

When a build is requested and an artifact already exists, the Pyrsia CLI returns the HTTP status code 400 (bad request), but should it be really an error?
If we allow users to send a build request explicitly, ArtifactAlreadyExists should occur frequently, but it does not seem a bad behavior. Probably we can make some changes to return the 200 code and just notify what happened via CLI messages.

Additional details

No response
@ihcomega56 ihcomega56 added enhancement New feature or request triage This is a new issue that needs to be reviewed at our Sprint Planning labels Nov 23, 2022
@betarelease betarelease added this to the 0.2.2 milestone Nov 28, 2022
@betarelease betarelease changed the title Stop regarding ArtifactAlreadyExists as an error? Stop treating ArtifactAlreadyExists as an error? Nov 28, 2022
@karolh2000 karolh2000 modified the milestones: 0.2.2, 0.2.3 Dec 15, 2022
@betarelease betarelease removed the triage This is a new issue that needs to be reviewed at our Sprint Planning label Jan 4, 2023
@betarelease betarelease modified the milestones: 0.2.3, 0.2.4 Jan 10, 2023
@betarelease
Copy link
Member

Since this is not a bad request, pick the appropriate status code to reflect what actually happened.

@dasmanas dasmanas assigned jperedadnr and dasmanas and unassigned jperedadnr Jan 19, 2023
@betarelease betarelease modified the milestones: 0.2.4, 0.2.5 Jan 24, 2023
@dasmanas dasmanas modified the milestones: 0.2.5, 0.2.4 Feb 3, 2023
@betarelease betarelease modified the milestones: 0.2.4, 0.2.5 Feb 7, 2023
@dasmanas dasmanas mentioned this issue Feb 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dasmanas dasmanas

Labels
enhancement New feature or request
Projects
Pyrsia Development
Status: Done
Milestone
0.2.5
Development

Successfully merging a pull request may close this issue.

Special handle for Artifact Already Exist while responding to Build Request dasmanas/pyrsia
7 participants
@betarelease @jperedadnr @tiainen @ihcomega56 @erwin1 @dasmanas @karolh2000