Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Code Coverage Run Fix #1458

Merged
merged 10 commits into from Jan 5, 2023
Merged

Conversation

dasmanas
Copy link
Contributor

@dasmanas dasmanas commented Dec 27, 2022

Description

This PR fixes Local Code Coverage Run. Switching to test run specific user in docker container before tarpaulin installation to avoid rust registry cache write permission issue

To test run ./tests/test_local_code_coverage.sh from pyrsia project context root. On successful encounter you will be able to see something similar to below.

pyrsia_code_coverage  | || 
pyrsia_code_coverage  | 49.82% coverage, 1384/2778 lines covered
pyrsia_code_coverage exited with code 0
[+] Running 3/3
 ⠿ Container pyrsia_code_coverage                 Removed                                                                                                                                                                                                       3.5s
 ⠿ Image local_code_coverage-codecoverage:latest  Removed                                                                                                                                                                                                       0.0s
 ⠿ Network local_code_coverage_default            Removed 

Screenshots (optional)

PR Checklist

Code Contributions

…lin installation to avoid rust registry cache write permission issue
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #1458 (bd88a41) into main (a251cd8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1458   +/-   ##
=======================================
  Coverage   50.20%   50.20%           
=======================================
  Files          51       51           
  Lines        2872     2872           
=======================================
  Hits         1442     1442           
  Misses       1430     1430           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dasmanas dasmanas added this to the 0.2.3 milestone Dec 27, 2022
@dasmanas dasmanas marked this pull request as ready for review December 27, 2022 18:52
@dasmanas dasmanas requested a review from a team as a code owner December 27, 2022 18:52
@dasmanas dasmanas requested review from efrisch and mseabornIBM and removed request for a team December 27, 2022 18:52
@dasmanas dasmanas added the bug Something isn't working label Dec 27, 2022
Copy link
Contributor

@sbtaylor15 sbtaylor15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@ihcomega56 ihcomega56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dasmanas dasmanas enabled auto-merge (squash) December 28, 2022 22:09
@dasmanas dasmanas merged commit 60a1351 into pyrsia:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants