undefined xhr and response objects on last catch

[sheymann]

Hello,

I chain queries as follows. The last one returns an error 400 with a JSON object in response that provides detailed information. This response should be available in the last catch but it is undefined, as well as the xhr object:

var qwestOpts = {
  cache: true,
  withCredentials: true
};

qwest.post(..., {...}, qwestOpts)

.then(function() {
  return qwest.get(..., null, qwestOpts);
})

.then(function(xhr, response) {
  ...
  return qwest.post(..., {...}, qwestOpts);
})

.then(function(xhr, response) {
  ...
  return qwest.post(..., {...}, qwestOpts) // throws error 400 (Bad Request)
})

.then(...)
.catch(function(error, xhr, response) {...}); // xhr === response === undefined

Tested using v4.1.1

[pyrsmk]

Are you catching the good error argument as expected?

[sheymann]

What do you mean?

[pyrsmk]

In the last catch, xhr and response are undefined. But what's the state of error, which is the first parameter of catch?

[sheymann]

Error is equal to the string "400 (Bad Request)"

[pyrsmk]

Which one? xD

[sheymann]

The error parameter of the last catch :)

[pyrsmk]

You gave me two different errors, which one is the error parameter? :p
And where is from the other one?

[sheymann]

Of I've erased the first error on the comments because it was a mistake, there is a one error only.

[pyrsmk]

Ah! My bad, I should have refresh the page ;)

So the good error is catched, it's just the arguments that are not valid. I'll look that tomorrow!

[sheymann]

Thanks!

[pyrsmk]

I think this is not a bug but the internal behavior of PinkySwear, the library that qwest uses for its promises layer. Since an error is thrown in a then, PinkySwear throws the error to the next catch without telling it to qwest. For this to work, I should wrap the then promise and add a try-catch block.

[pyrsmk]

Then, I think I can't deal with this issue because I can't see a way to deal with the PinkySwear's internal routines.

Can't you use the grouped requests as described in the documentation?

[pyrsmk]

I'm closing this for idling ;)