Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to allow images to be displayed by default. #5

Open
MarkMaldaba opened this issue Apr 19, 2013 · 2 comments
Open

Comments

@MarkMaldaba
Copy link

Currently, image display defaults to off.

If you click 'show images' on a page that has images, then the state of the setting is remembered in a cookie, so subsequent pages automatically show images on load (on the current computer/browser, for as long as the cookie persists).

However, this link isn't necessarily obvious, and users may not notice that this feature is available. It also requires that you manually enable it each time you visit the site from a different machine.

There should be a user preference to 'display image attachments inline'. This should work like other user preferences - a default can be set for the site, and you can specify whether users can over-ride this default, and if they can over-ride it, users get the three options 'site default', 'yes' and 'no.

I imagine all the UI stuff will be handled automatically by Bugzilla and that you just need to define the parameter, and update the code to make use of it.

@pyrzak
Copy link
Owner

pyrzak commented Aug 3, 2013

You are correct. Ideally it would be a preference. It would be turned off by default and it would have this really great subtle way of letting users know that they could see the image inline. Unfortunately doing this via a hook, at the time I wrote this plugin, was much harder to do and requiring editing the backend bugzilla database. Since I am only familiar with the Bugzilla UI code this was beyond my capabilities. Unfortunately, your imagination is far from how the Bugzilla code works and would require me to spend more time on this plugin, getting familiar with the Perl and MySQL schema than I am willing to do.

That being said, thanks for the feedback! I do appreciate it, and if you decide to write a plugin that does what you describe let me know and I'll link to it.

@MarkMaldaba
Copy link
Author

Hi Pyrzak, thanks for the reply.

I've done a little investigating, and it looks like this is now quite easy, in more recent Bugzilla versions:

Is that something you think you could add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants