Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferred style format of new ESDA estimators #118

Closed
jeffcsauer opened this issue May 29, 2020 · 2 comments
Closed

Preferred style format of new ESDA estimators #118

jeffcsauer opened this issue May 29, 2020 · 2 comments

Comments

@jeffcsauer
Copy link
Collaborator

jeffcsauer commented May 29, 2020

As discussed at the 5/22 and 5/29 GSOC2020 ESDA calls, there is an open question as to what style format the new ESDA estimators might (or should) take. In general, three potential candidate formats were discussed:

In my current draft of each estimator, I've opted for a scikit-learn format. I also drafted a few of them in legacy format (see Join_Counts_Local_old for legacy format vs Local_Join_Counts for scikit-learn format in previous link).

Wanted to raise this issue and open it up for discussion!

(can't seem to tag the issue for GSOC2020 or a project-specific GSOC2020_ESDA_ENH...)

@knaaptime
Copy link
Member

as this is being reworked anyway, it might be an opportune time to move to pep8 class formatting (i.e. remove underscores)

@jeffcsauer
Copy link
Collaborator Author

Applied PEP8 formatting and sticking with scikit-learn for the moment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants