Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Numba < 0.47 #142

Closed
stuartarchibald opened this issue Aug 3, 2020 · 2 comments
Closed

Issue with Numba < 0.47 #142

stuartarchibald opened this issue Aug 3, 2020 · 2 comments

Comments

@stuartarchibald
Copy link

This was reported on the Numba issue tracker, unfortunately with no reproducer: numba/numba#6059 and I'm afraid I'm not familiar enough with this package to construct one. However, guessing from the traceback, I think ESDA might need to pin Numba >= 0.47 to ensure this problem isn't hit. I can prepare a PR if it helps?

@stuartarchibald stuartarchibald changed the title Issue with Numba <= 0.47 Issue with Numba < 0.47 Aug 3, 2020
@ljwolf
Copy link
Member

ljwolf commented Aug 3, 2020

Hi, thanks for the feedback! We don't require numba, although we do recommend that users have it so that they get the fastest verisons of our algorithms out there.

We will take a look at recommending numba > 0.50.1, since we also hit this when building the numba implementation, or at least documenting the issue.

@stuartarchibald
Copy link
Author

Great, thanks for adding #143, please do close this as you see fit!
If you've any issues with Numba itself please feel free to raise them on our issue tracker too :)
Thanks again!

@sjsrey sjsrey closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants