Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pysal/inequality vs. pysal/segregation? #40

Closed
jGaboardi opened this issue Dec 5, 2022 · 6 comments
Closed

pysal/inequality vs. pysal/segregation? #40

jGaboardi opened this issue Dec 5, 2022 · 6 comments

Comments

@jGaboardi
Copy link
Member

At some point we should take a deep dive to figure out the overlap between inequality and segregation, and determine how much/if any of inequality can be consumed by segregation (or vice-versa). Or even if inequality should be entirely cannibalized by segregation.

@martinfleis
Copy link
Member

I like that inequality is very lean package. momepy uses Theil and Gini and I would rather not depend on whole segregation here with rvlib et al as dependencies. But I can easily move those simple formulas over and not depend on any of those.

From a wider perspective, it makes sense to merge this stuff with something else, it is tiny and the last release was 4 years ago, so not even active.

@jGaboardi
Copy link
Member Author

To be clear & transparent, I think that the most reasonable path forward is for inequality to remain its own package. I was simply throwing out some possible ideas.

As for the maintenance side, I have been spending time cleaning inequality up over the last month and would very much like to get a fresh release out to be included in the next PySAL meta release.

@knaaptime
Copy link
Member

serge and i have talked about this once or twice before. I tend to agree a merger makes sense

if it would help, I think its probably worthwhile to make rvlib an optional dependency (and fallback to the slower sampler otherwise), so segregation's requirement footprint should become pretty standard (i think quilt can go too)

@martinfleis
Copy link
Member

make rvlib an optional dependency

That would be good!

@sjsrey
Copy link
Member

sjsrey commented Dec 11, 2023

I think inequality and segregation should remain separate.

There is a bunch of inequality enhancements I have code for but have not pushed up, related to an nsf project that just is winding down.

@jGaboardi
Copy link
Member Author

The big boss has spoken. I'll close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants