Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #489

Closed
jarrodmillman opened this issue Nov 15, 2022 · 9 comments
Closed

New release? #489

jarrodmillman opened this issue Nov 15, 2022 · 9 comments

Comments

@jarrodmillman
Copy link

Would it be possible to release a new version of libpysal that includes: #472

We plan to release NetworkX 3.0 soon (https://github.com/networkx/networkx/milestone/15) and would like to reenable to geospatial gallery examples (networkx/networkx#5840).

@martinfleis
Copy link
Member

Hi, our plan was to have a minor release by the end of the year with #477 and #484 but given #472 is a fix, we can get a patch release with that one out quickly.

@sjsrey @jGaboardi @knaaptime @ljwolf thoughts? We would need to cherry-pick some commits for that but it should be doable.

@jGaboardi
Copy link
Member

I am for it.

@knaaptime
Copy link
Member

cool with me!

@ljwolf
Copy link
Member

ljwolf commented Nov 16, 2022

Yeah, I'm fine with a bugfix release, then a larger point release with the additional stuff. I'd be fine with this as 4.6.3 and then the release with the deprecations and weights changes as 4.7

@sjsrey
Copy link
Member

sjsrey commented Nov 17, 2022

Sounds good to me. I should be able to start on this tomorrow afternoon.

@sjsrey
Copy link
Member

sjsrey commented Nov 17, 2022

4.7.0 is now released

@sjsrey
Copy link
Member

sjsrey commented Nov 17, 2022

Hi, our plan was to have a minor release by the end of the year with #477 and #484 but given #472 is a fix, we can get a patch release with that one out quickly.

@sjsrey @jGaboardi @knaaptime @ljwolf thoughts? We would need to cherry-pick some commits for that but it should be doable.

#472 was merged, but #477 and #484 have not been merged - I'm not clear what needs to be cherry picked?

@sjsrey
Copy link
Member

sjsrey commented Nov 28, 2022

Hi, our plan was to have a minor release by the end of the year with #477 and #484 but given #472 is a fix, we can get a patch release with that one out quickly.
@sjsrey @jGaboardi @knaaptime @ljwolf thoughts? We would need to cherry-pick some commits for that but it should be doable.

#472 was merged, but #477 and #484 have not been merged - I'm not clear what needs to be cherry picked?

@martinfleis can you let me know if this can be closed, or do we need to revisit the cherry picking?

@martinfleis
Copy link
Member

It is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants