Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper shapely being pulled into DEV CI? #612

Closed
jGaboardi opened this issue Oct 30, 2023 · 7 comments
Closed

proper shapely being pulled into DEV CI? #612

jGaboardi opened this issue Oct 30, 2023 · 7 comments
Assignees
@jGaboardi
Labels
ci

Comments

@jGaboardi
Copy link
Member

Not sure if it has anything to do with the current test_weights.py::TestW::test_plot failure, but the DEV environment has shapely=2.0.1+53.g9540b77 listed, not a bleeding edged shapely=2.0.2+....

Also, we should be printing out the spatial versions available through geopandas as part of the CI run. I'll put in the PR now.
@jGaboardi jGaboardi added the ci label Oct 30, 2023
@jGaboardi jGaboardi self-assigned this Oct 30, 2023
@jGaboardi jGaboardi mentioned this issue Oct 30, 2023
Merged
@jGaboardi
Copy link
Member Author

jGaboardi commented Oct 30, 2023 •
edited

Seeing same type of failures in geopandas, along with the "wrong" shapely version.

@martinfleis
Copy link
Member

That is because shapely 2.0.2 was tagged and released from a maintenance branch, not main. It is the latest shapely, their versioning is just off.

cc @jorisvandenbossche

@jGaboardi
Copy link
Member Author

So nothing to do with these failures, correct? If so, I'll close this issue.

@martinfleis
Copy link
Member

So nothing to do with these failures, correct?

You mean the test_weights.py::TestW::test_plot? I don't know where that comes from.

@jGaboardi
Copy link
Member Author

Can't seem to replicate that error (at least on macOS), with the ci/312-DEV.yml environment.

@martinfleis
Copy link
Member

I think it will be pandas block manager warning. To be resolved in geopandas.

@jGaboardi
Copy link
Member Author

Closing here then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jGaboardi @martinfleis