Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclosure has problems with rivers #270

Closed
ale-v opened this issue Mar 8, 2021 · 1 comment · Fixed by #288
Closed

Enclosure has problems with rivers #270

ale-v opened this issue Mar 8, 2021 · 1 comment · Fixed by #288

Comments

@ale-v
Copy link

ale-v commented Mar 8, 2021

Although I specified streets and land as spatial constraints for generating the enclosures, the momepy.enclosures wrongly creates enclosures in rivers. See the yellow areas in the pic.
wards

@martinfleis
Copy link
Member

I think that we'll have to add some spatial filter before we return polygons. The operation itself is just polygonize, that's why these areas are returned. I just don't want to do it every time because it can be expensive. Will have to figure out some smart solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants