Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitcount #307

Closed
martinfleis opened this issue Oct 3, 2021 · 7 comments
Closed

gitcount #307

martinfleis opened this issue Oct 3, 2021 · 7 comments

Comments

@martinfleis
Copy link
Member

martinfleis commented Oct 3, 2021

@jGaboardi do we need the gitcount notebook here? I am not sure when it is called.

I don't want to use it to generate an automatic changelog if that won't cause trouble. It is IMHO too noisy and I prefer to keep only user-facing changes in the changelog.

@jGaboardi
Copy link
Member

It is called during the release action (e.g. here for libpysal). If momepy will not be running an automated CHANGELOG then you are correct, there is no reason to have a gitcount.ipynb. (Is this correct, @sjsrey?)

@martinfleis
Copy link
Member Author

The release action we have here assumes an updated changelog before you make a tag.

@sjsrey
Copy link
Member

sjsrey commented Oct 3, 2021

I think the automatic change log is causing more problems than it solves.

It might be better to use the git count to get some summary statistics, and then use those in a handcrafted change log.

@jGaboardi
Copy link
Member

I think the automatic change log is causing more problems than it solves.

It might be better to use the git count to get some summary statistics, and then use those in a handcrafted change log.

Probably a good idea, as the original intent (IIRC) was to make sure that all contributors received credit.

@martinfleis
Copy link
Member Author

I guess that this resolves a lot of related issues - https://github.blog/2021-10-04-beta-github-releases-improving-release-experience/

@jGaboardi
Copy link
Member

Interesting...

@jGaboardi
Copy link
Member

@martinfleis I am going to close this for now. Please re-open if we feel it's still something we need to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants