Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .append method for dataframes #383

Closed
jGaboardi opened this issue Sep 8, 2022 · 0 comments · Fixed by #384
Closed

update .append method for dataframes #383

jGaboardi opened this issue Sep 8, 2022 · 0 comments · Fixed by #384
Assignees

Comments

@jGaboardi
Copy link
Member

Description / Summary

Replace old .append() method (that's causes the warning below) with pandas.concat([df1, df2]).

momepy/preprocessing.py:273: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.

return df.append(
gpd.GeoDataFrame({df.geometry.name: final}, geometry=df.geometry.name),
ignore_index=True,
)
return df.append(final, ignore_index=True)

Probably occurs in more places within momepy than only in preprocessing.

xref #382

Value / benefit

Need to keep up with current pandas.

Implementation details

No response

Tasks to complete

No response

@jGaboardi jGaboardi added the enhancement New feature or request label Sep 8, 2022
@martinfleis martinfleis self-assigned this Sep 9, 2022
@jGaboardi jGaboardi added rough edge and removed enhancement New feature or request labels Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants