Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failure – TestElements.test_Blocks_non_default_index #564

Closed
jGaboardi opened this issue Apr 2, 2024 · 3 comments
Closed

CI failure – TestElements.test_Blocks_non_default_index #564

jGaboardi opened this issue Apr 2, 2024 · 3 comments
Assignees
Labels
testing/CI upstream issue Issue to be fixed in an upstream package

Comments

@jGaboardi
Copy link
Member

  • CI failureTestElements.test_Blocks_non_default_index
  • seems to be relating to pandas
self = <momepy.tests.test_elements.TestElements object at 0x7f103b9c1b80>

    def test_Blocks_non_default_index(self):
        tessellation = self.df_tessellation.copy()
        tessellation.index = tessellation.index * 3
        buildings = self.df_buildings.copy()
        buildings.index = buildings.index * 5
    
        blocks = mm.Blocks(tessellation, self.df_streets, buildings, "bID", "uID")
    
        assert_index_equal(tessellation.index, blocks.tessellation_id.index)
>       assert_index_equal(buildings.index, blocks.buildings_id.index)
E       AssertionError: Index are different
E       
E       Index values are different (100.0 %)
E       [left]:  RangeIndex(start=0, stop=720, step=5)
E       [right]: Index([655, 635, 660, 640, 650, 630, 645, 625, 570, 665,
E              ...
E              405, 365, 610, 615, 360, 355, 350, 345, 340, 335],
E             dtype='int64', length=144)

momepy/tests/test_elements.py:134: AssertionError
@martinfleis
Copy link
Member

I think it is caused by geopandas/geopandas#2353 but I am not sure if it is expected or a regression yet. Will need to have a proper look.

@martinfleis
Copy link
Member

Upstream issue -> geopandas/geopandas#3239

@martinfleis martinfleis added the upstream issue Issue to be fixed in an upstream package label Apr 2, 2024
@jGaboardi
Copy link
Member Author

Let's close out here or keep open until actually fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing/CI upstream issue Issue to be fixed in an upstream package
Projects
None yet
Development

No branches or pull requests

2 participants