Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrections for README #106

Closed
jGaboardi opened this issue Jan 13, 2021 · 5 comments
Closed

corrections for README #106

jGaboardi opened this issue Jan 13, 2021 · 5 comments
Assignees
Labels
bug Something isn't working docs priority: high

Comments

@jGaboardi
Copy link
Member

jGaboardi commented Jan 13, 2021

There are several errors in the README.md that was just merged. It's best to not merge directly to main and to have another person review PRs for this reason.

@knaaptime
Copy link
Member

these haven't been addressed

@xf37
Copy link
Collaborator

xf37 commented Jan 13, 2021

these haven't been addressed

I did not get it. These have been addressed from my end.

@knaaptime
Copy link
Member

sorry, you're right! i was looking at the links in this issue instead of the current code

@jGaboardi
Copy link
Member Author

these haven't been addressed

I did not get it. These have been addressed from my end.

@xf37 I think @knaaptime missed it because there was no PR for the issue. This is another reason why we should never merge directly to main (unless absolutely necessary). We should try to stay to the PR+Review before merge whenever possible.

@xf37
Copy link
Collaborator

xf37 commented Jan 13, 2021

these haven't been addressed

I did not get it. These have been addressed from my end.

@xf37 I think @knaaptime missed it because there was no PR for the issue. This is another reason why we should never merge directly to main (unless absolutely necessary). We should try to stay to the PR+Review before merge whenever possible.

Got it. Will do it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs priority: high
Projects
None yet
Development

No branches or pull requests

3 participants