Consider documenting units for the max_coverage parameter of MCLP/LSCP.from_geodataframe

[apulverizer]

Noticed this as part of openjournals/joss-reviews#3330

It's a bit unclear what the distance unit actually is. I assume it's in the units of the coordinate system that the geodataframes are in. From a usability perspective, it'd be nice to at least document that. Even better, would be to support specifying the units and internally converting it.

Something like:

mclp_from_geodataframe = MCLP.from_geodataframe(
    clients_snapped, 
    facilities_snapped, 
    "geometry", 
    "geometry", 
    "demand", 
    100,
    service_radius_units="miles",
    p_facilities=P_FACILITIES,
    distance_metric="euclidean",
)

[jGaboardi]

@apulverizer This is a nice suggestion, and one we have considered before. However, as with other PySAL submodules, we expect the user to have performed preprocessing and to know the projection/coordinate system. Therefore, the user must specify only distance unit itself. Considering the naming max_coverage was recently changed to service_radius in order to more accurately reflect facility location terminology.