Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k-nearest pmedian failures due to zip(strict=True) #402

Closed
jGaboardi opened this issue Oct 14, 2023 · 0 comments · Fixed by #403
Closed

k-nearest pmedian failures due to zip(strict=True) #402

jGaboardi opened this issue Oct 14, 2023 · 0 comments · Fixed by #403
Assignees
@jGaboardi
Labels
bug Something isn't working locate

Comments

@jGaboardi
Copy link
Member

2023-10-13 CI – py38

k-nearest pmedian failures due to zip(strict=True)

FAILED spopt/tests/test_knearest_p_median.py::TestKNearestPMedian::test_knearest_p_median_from_geodataframe - TypeError: zip() takes no keyword arguments
FAILED spopt/tests/test_knearest_p_median.py::TestKNearestPMedian::test_knearest_p_median_from_geodataframe_no_results - TypeError: zip() takes no keyword arguments
FAILED spopt/tests/test_knearest_p_median.py::TestKNearestPMedian::test_solve - TypeError: zip() takes no keyword arguments

This seems to have flown under the radar due to #386. I will remove the strict=True keyword for now. We can re-add once python=3.{8,9} are dropped and python=3.12 is added , which will be soon. I anticipate this for a v0.6.1 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
bug Something isn't working locate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove zip(strict=True) in k-nearest p-median jGaboardi/spopt
1 participant
@jGaboardi