Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deleted logos #89

Closed
jGaboardi opened this issue Jan 4, 2021 · 0 comments
Closed

replace deleted logos #89

jGaboardi opened this issue Jan 4, 2021 · 0 comments
Assignees
@jGaboardi @xf37
Labels
maintenance
Projects
Release v0.1.0

Comments

@jGaboardi
Copy link
Member

jGaboardi commented Jan 4, 2021 •
edited

The PySAL banner (pysal_banner.svg) was deleted from the repo in #86, as well as the .ico image being swapped out for the old PySAL one. Right now we need to add that back. In the the future, it is important to perform code review as often and as thoroughly as possible to prevent this from happening, especially with PRs touching 172 files. I am always available for code review.
@jGaboardi jGaboardi mentioned this issue Jan 4, 2021
Merged
@jGaboardi jGaboardi added this to In progress in Release v0.1.0 Jan 4, 2021
@knaaptime knaaptime moved this from In progress to Done in Release v0.1.0 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

@xf37 xf37

Labels
maintenance
Projects
No open projects
Release v0.1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jGaboardi @xf37