Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get shared object suffix from EXT_SUFFIX #1147

Merged
merged 1 commit into from Jan 3, 2023

Conversation

sirno
Copy link
Contributor

@sirno sirno commented Nov 10, 2022

Hey,

I ran into an issue installing pysam with python 3.11.0. It seems that the SO configuration has been deprecated and EXT_SUFFIX should be used instead.

Also note that using get_config_var to access would have likely triggered a deprecation warning :)

Lets see what the actions say, but in case this causes test failures for older versions, I can adjust this to make it conditional.

Cheers

Copy link
Contributor

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me, on 3.11 and 3.6, so I guess the tests would pass.

mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Nov 17, 2022
export HDF5_DIR=/usr/local/Cellar/hdf5/1.12.2_2; pip install h5py,
get pysam from pysam-developers/pysam#1147
@jayaddison
Copy link

I think this would also resolve #1154.

@sirno could you check the rest of the codebase for references to the SO config var?

@jmarshall jmarshall merged commit da8722e into pysam-developers:master Jan 3, 2023
@jmarshall
Copy link
Member

jmarshall commented Jan 3, 2023

Thanks, I've merged this and updated it to use both EXT_SUFFIX and SO everywhere. (According to pysam/NEWS we still support back to Python 3.2. Some early 3.2.x and 3.3.x versions do not define EXT_SUFFIX, so for now we still need to consult both config variables.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants