Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minimal pyproject.toml for PEP517 #1168

Merged
merged 1 commit into from Mar 8, 2023

Conversation

afg1
Copy link
Contributor

@afg1 afg1 commented Feb 9, 2023

This PR allows pip isolated builds to work, but still uses the same build infrastructure as always, so shouldn't break anything.

I needed this because I develop a pipeline running on python 3.11, for which there isn't a wheel yet. The dependency manager I'm using (poetry) does all its builds in isolated environments, which is fine when setup.py doesn't depend on anything except setuptools and/or wheel but has problems when you need e.g. cython

The solution is to add a minimal pyproject.toml file that includes the build dependencies, and specifies the correct build backend. That way, the isolated enviroment used for the build ends up with Cython, and everyone is happy.

I added some stuff to the project description, but this is all already in setup.cfg I think, so could be removed. Ideally, everything would end up in the pyproject.toml but I didn't want to break anything since I'm not 100% sure how this all interacts with e.g. CI and pushing to PyPI.

This allows pip isolated builds to work, but still uses the same build infrastructure as always

I added some stuff to the project description, but this is all already in setup.cfg, so could be removed really
@sinoroc
Copy link

sinoroc commented Feb 15, 2023

Related:

@sinoroc
Copy link

sinoroc commented Feb 15, 2023

@afg1 For a first step, you should have only the [build-system] section, but without the :__legacy__ part which seems unnecessary. https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

@AndreasHeger AndreasHeger merged commit 12d9453 into pysam-developers:master Mar 8, 2023
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants