Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for str(pysam.FastqProxy()) segfault #886

Merged
merged 1 commit into from May 23, 2020

Conversation

graingert
Copy link
Contributor

No description provided.

@graingert
Copy link
Contributor Author

here's a demo on ubuntu: https://github.com/graingert/pysam-segfault

Step 7/7 : RUN ~/.virtualenvs/pysam/bin/python -c "str(__import__('pysam').FastqProxy())"
 ---> Running in d8adac336dd5
Segmentation fault (core dumped)
The command '/bin/sh -c ~/.virtualenvs/pysam/bin/python -c "str(__import__('pysam').FastqProxy())"' returned a non-zero code: 139

@AndreasHeger AndreasHeger merged commit a7cb367 into pysam-developers:master May 23, 2020
@AndreasHeger
Copy link
Contributor

Thanks, FastqProxy now raises ValueError if instantiated directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants