Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: setup.py deprecated by pip #1051

Closed
10 tasks done
jklenzing opened this issue Oct 21, 2022 · 10 comments
Closed
10 tasks done

DEP: setup.py deprecated by pip #1051

jklenzing opened this issue Oct 21, 2022 · 10 comments
Assignees
Milestone

Comments

@jklenzing
Copy link
Member

jklenzing commented Oct 21, 2022

Is your feature request related to a problem? Please describe.
From the unit tests at pysatCDAAC:

 DEPRECATION: pysat is being installed using the legacy 'setup.py install' method, because it does not have a 
'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change.

Describe the solution you'd like
pyproject.toml

Describe alternatives you've considered
🎡

Projects to update

@rstoneback
Copy link
Collaborator

image

@jklenzing
Copy link
Member Author

I'm very close to a functional version of pysatNASA using pyproject.toml. Two problems left to solve:

  • NEP 29 compliance
  • pysatCDF install

I may may try on another package first to simplify dependencies

@jklenzing
Copy link
Member Author

Sample version up at pysat/pysatCDAAC#39

@jklenzing
Copy link
Member Author

From the test cases so far, I've been able to consolidate metadata / settings info from 5 files to 2.

@jklenzing
Copy link
Member Author

Dropping open pulls down to drafts until we can discuss at the next meeting. Comments/questions are welcome. Currently researching background more.

@jklenzing jklenzing added this to the Future milestone Nov 9, 2022
@jklenzing
Copy link
Member Author

Notes from discussion today:

  • use setup.cfg instead of tox.ini
  • maintain setup.py for backward compatibility
  • research parsers for readthedocs integration

@jklenzing
Copy link
Member Author

pip 23.1 has been released and is wreaking havoc in the tests. This issue should be accelerated.

@jklenzing
Copy link
Member Author

Some things that are relevant to our build processes for pip 23.1.0 (Released 4-15-2023). From https://pip.pypa.io/en/stable/news/

--no-binary does not imply setup.py install anymore. Instead a wheel will be built locally and installed.

--no-binary does not disable the cache of locally built wheels anymore. It only means “don’t download wheels”.

Remove setup.py install fallback when building a wheel failed for projects without pyproject.toml.

When the wheel package is not installed, pip now uses the default build backend instead of setup.py install and setup.py develop for project without pyproject.toml.

@jklenzing
Copy link
Member Author

TODO: open issues at remaining packages, close this one.

@jklenzing
Copy link
Member Author

Issues added to remaining packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants