Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better exposure for methods in pysat._files #336

Closed
rstoneback opened this issue Dec 20, 2019 · 6 comments · Fixed by #505
Closed

Provide better exposure for methods in pysat._files #336

rstoneback opened this issue Dec 20, 2019 · 6 comments · Fixed by #505

Comments

@rstoneback
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Users may not be aware of built in file methods that could make their lives easier when adding new instruments.

Describe the solution you'd like
rename pysat._files.py to pysat.files.py

Describe alternatives you've considered

Additional context

@rstoneback rstoneback added this to the 3.0.0 Release milestone Dec 20, 2019
@jklenzing jklenzing self-assigned this Jul 1, 2020
@jklenzing jklenzing linked a pull request Jul 1, 2020 that will close this issue
10 tasks
@jklenzing
Copy link
Member

I have a test branch up in #454. The change is straightforward and works, but rapidly becomes confusing to me due to the existence of the pysat.Files class and the methods under pysat.files, which also contains the Files class.

Possible routes:

  • move the methods to pysat.utils.files and leave the main class file hidden.
  • break these apart at the top level with a rename of one or the other

@rstoneback
Copy link
Collaborator Author

Moving the relevant methods to pysat.utils.files sounds like a good plan to me.

@jklenzing
Copy link
Member

OK. I'll start mocking up a replacement PR. This will require deprecation warnings.

@jklenzing jklenzing linked a pull request Aug 5, 2020 that will close this issue
10 tasks
@jklenzing
Copy link
Member

Looking over the code, it looks like from_os should really be moved from the class to utils.files as well. Thoughts?

@rstoneback
Copy link
Collaborator Author

rstoneback commented Aug 10, 2020 via email

@jklenzing
Copy link
Member

Closing with merge of #505

pysat 3.0.0 -- changes to code structure automation moved this from In progress to Done Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants