Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: unit tests need to be compliant with windows directories #790

Closed
jklenzing opened this issue May 18, 2021 · 1 comment · Fixed by #804
Closed

BUG: unit tests need to be compliant with windows directories #790

jklenzing opened this issue May 18, 2021 · 1 comment · Fixed by #804
Assignees
@rstoneback
Labels
bug good first issue
Milestone
3.0.1 Release

Comments

@jklenzing
Copy link
Member

Describe the bug
Some of the unit tests assume unix style directories, which break the windows tests

To Reproduce
See results in https://github.com/pysat/pysat/runs/2606331706?check_suite_focus=true

Expected behavior
os.path.join should be used.

Additional context

pysat/pysat/tests/test_utils_files.py

Line 174 in 900dead

templ = '{platform}/{name}/{tag}/{inst_id}'

@jklenzing jklenzing added the bug label May 18, 2021
@jklenzing jklenzing mentioned this issue May 18, 2021
Closed
@jklenzing jklenzing added this to the 3.0.1 Release milestone May 19, 2021
@rstoneback rstoneback self-assigned this May 27, 2021
@rstoneback rstoneback mentioned this issue May 27, 2021
Merged
10 tasks
@rstoneback rstoneback linked a pull request May 28, 2021 that will close this issue
BUG: Windows Compliance Update #804
Merged
10 tasks
@jklenzing
Copy link
Member Author

Closing with merge of #804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoneback rstoneback

Labels
bug good first issue
Projects
None yet
Milestone
3.0.1 Release
Development

Successfully merging a pull request may close this issue.

BUG: Windows Compliance Update pysat/pysat
2 participants
@rstoneback @jklenzing