Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiating with platform/name and inst_module #850

Closed
rstoneback opened this issue Jul 20, 2021 · 4 comments · Fixed by #917
Closed

Instantiating with platform/name and inst_module #850

rstoneback opened this issue Jul 20, 2021 · 4 comments · Fixed by #917

Comments

@rstoneback
Copy link
Collaborator

Describe the bug
A user can create an instantiation call with a supplied platform/name, as well as an inconsistent module for inst_module, and the pysat Instrument object will create itself despite the inconsistent inputs.

To Reproduce
Steps to reproduce the behavior:

In [8]: inst = pysat.Instrument('cnofs', 'ivm', inst_module=pysatNASA.instruments.cnofs_vefi, tag='dc_b')                                                                                                                   

In [9]: inst.name                                                                                                                                                                                                           
Out[9]: 'vefi'

Expected behavior
A warning or error given the inconsistency.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS
  • Version Python 3.8
  • Other details about your setup that could be relevant

Additional context
Add any other context about the problem here.

@rstoneback rstoneback added the bug label Jul 26, 2021
@rstoneback rstoneback added this to To do in User Experience Enhancements via automation Jul 28, 2021
@rstoneback rstoneback added this to the 3.1.0 Release milestone Jul 28, 2021
@rstoneback
Copy link
Collaborator Author

Don't forget to add a unit test for every bug discovered.

@jklenzing
Copy link
Member

Requires merge of #903 before new tests can be added

@jklenzing jklenzing self-assigned this Sep 30, 2021
@jklenzing
Copy link
Member

I think a warning would be appropriate here.

@jklenzing
Copy link
Member

Closing with merge of #917

User Experience Enhancements automation moved this from To do to Done Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants