Remove dependency on PyScaffold during builds #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
force-pushed
the
remove-build-dependency
branch
5 times, most recently
from
ec8268d
to
02fb829
Compare
abravalheri
force-pushed
the
remove-build-dependency
branch
3 times, most recently
from
822153f
to
039405e
Compare
As discussed in pyscaffold#256, after pytest-runner was deprecated and removed, the only strong reason for having PyScaffold required during builds is to use setuptools_scm. Docs can easily be generated via Makefile (already created by default) or tox/nox (the new tox template already contains a task for the docs). A way of removing this dependency is by injecting setuptools_scm directly on the `setup.py` template. In the future something similar can be done for `pyproject.toml` (when it is generated by default). This change is an attempt of doing that. As a direct consequence, we also remove PyScaffold as a build-time dependency of itself, which makes things easier.
- Remove unecessary egg_info - Remove unsupported Python version - Remove coverage combine (it seams pytest-cov already do that)
abravalheri
force-pushed
the
remove-build-dependency
branch
5 times, most recently
from
a236d89
to
b3cc601
Compare
abravalheri
force-pushed
the
remove-build-dependency
branch
from
b3cc601
to
9cbef99
Compare
|
By the general comments in #256 and the quick hint in #289 (implying that in v4 PyScaffold will have runtime dependencies, but not "build-time" ones), I assume this PR is aligned with the current understanding on how PyScaffold should move forward. So now that the tests are fixed on Windows, I will merge the PR into v4.0.x. The changes can also be reviewed/undone prior to the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #256, after
pytest-runnerwas deprecated and removed, the only strong reason for having PyScaffold required during builds is to usesetuptools_scm. Docs can easily be generated via Makefile (already created by default) ortox/nox(the newtoxtemplate already contains a task for the docs).A way of removing this dependency is by injecting
setuptools_scmdirectly on thesetup.pytemplate. In the future something similar can be done forpyproject.toml(when it is generated by default).This change is an attempt of doing that. As a direct consequence, we also remove PyScaffold as a build-time dependency of itself, which makes things easier. It also closes #245.