Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default REPL indentUnit to 4 #531

Closed
3 tasks done
HighDiceRoller opened this issue Jun 21, 2022 · 1 comment · Fixed by #814
Closed
3 tasks done

Default REPL indentUnit to 4 #531

HighDiceRoller opened this issue Jun 21, 2022 · 1 comment · Fixed by #814
Labels
type: feature New feature or request

Comments

@HighDiceRoller
Copy link

HighDiceRoller commented Jun 21, 2022 •
edited
Loading

Checklist

  • I added a descriptive title
  • I searched for other issues and couldn't find a duplication
  • I already searched in Google and didn't find any good information or help

What is the issue/comment/problem?

Currently the indent in the REPL is 2 spaces. I propose that this be changed to 4 spaces. This follows PEP 8 and the majority of the examples.
@HighDiceRoller HighDiceRoller added the needs-triage Issue needs triage label Jun 21, 2022
@marimeireles
Copy link
Member

The indent can be 4 too, as in, it won't crash.
But I agree we should default it to 4 instead of 2.

@marimeireles marimeireles added the type: feature New feature or request label Jun 21, 2022
@marimeireles marimeireles changed the title Change REPL indentUnit to 4 Default REPL indentUnit to 4 Jun 21, 2022
@marimeireles marimeireles removed the needs-triage Issue needs triage label Jun 21, 2022
@JeffersGlass JeffersGlass mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Codemirror 6 (py-repl) JeffersGlass/pyscript
2 participants
@marimeireles @HighDiceRoller