Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to send HTML or plain Text to banner #924

Closed
3 tasks done
FabioRosado opened this issue Nov 8, 2022 · 0 comments · Fixed by #947
Closed
3 tasks done

Add flag to send HTML or plain Text to banner #924

FabioRosado opened this issue Nov 8, 2022 · 0 comments · Fixed by #947
Labels
good first issue Good for newcomers type: feature New feature or request

Comments

@FabioRosado
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched for other issues and couldn't find a duplication
  • I already searched in Google and didn't find any good information or help

What is the issue/comment/problem?

While chatting with Antonio about #909 he mentioned that maybe we shouldn't put the text in the banner with innerHTML due to the issues we have seen with escaping characters. Ideally, we would have the possibility to choose if the text in the banner should be added to innerHTML or contextText instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add flag to send HTML or plain Text to banner FabioRosado/pyscript
1 participant
@FabioRosado