Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repl Output is replaced even if it shouldn't (i.e. loops) #975

Closed
3 tasks done
limitcracker opened this issue Nov 23, 2022 · 4 comments · Fixed by #1106
Closed
3 tasks done

Repl Output is replaced even if it shouldn't (i.e. loops) #975

limitcracker opened this issue Nov 23, 2022 · 4 comments · Fixed by #1106
Labels
needs-triage Issue needs triage type: bug Something isn't working

Comments

@limitcracker
Copy link

Checklist

  • I added a descriptive title
  • I searched for other issues and couldn't find a solution or duplication
  • I already searched in Google and didn't find any good information or help

What happened?

In latest version when I have a loop inside a <py-repl> I get the output replaced each time instead of appended.

i.e.

<py-repl id="my-repl-11nov22-1333" auto-generate="true"> 
for i in range(10):
    print(i)
</py-repl>

What browsers are you seeing the problem on? (if applicable)

Chrome

Console info

No response

Additional Context

No response

@limitcracker limitcracker added needs-triage Issue needs triage type: bug Something isn't working labels Nov 23, 2022
@limitcracker limitcracker changed the title Repl Output is replaced even it shouldn't (i.e. loops) Repl Output is replaced even if it shouldn't (i.e. loops) Nov 23, 2022
@limitcracker
Copy link
Author

is there an option for the repl tag in order to not reload like it did in the alpha version?

@marimeireles
Copy link
Member

Yep! Good catch, I'm looking into it.
Thanks @limitcracker :)
Also if you want to dive into debugging feel free to!

@limitcracker
Copy link
Author

limitcracker commented Dec 24, 2022

Merry Christmas, @marimeireles !
I see that the loops output has been fixed and now it been appended.

Image 2022-12-24 at 9 28 38 PM

But is there a way to have a setting in order to be replaced if we need to?
i.e.
<py-repl id="my-repl1" auto-replace-output="true"> </py-repl>

Any ideas?

@marimeireles
Copy link
Member

Yes! The output support was removed but it's soon to be reintroduced by Jeff's PR #1063!
So just keep an eye for when that change roll in I guess :)
Thanks for the feedback and hope you had nice holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue needs triage type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants