Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package dependency torch version 1.9.0+ #24

Closed
anthony2261 opened this issue Feb 7, 2022 · 2 comments
Closed

Package dependency torch version 1.9.0+ #24

anthony2261 opened this issue Feb 7, 2022 · 2 comments

Comments

@anthony2261
Copy link

Not really an issue, but we use the LTS version of torch, which is currently 1.8.2, but pysentimiento requires newer versions of torch. Is this solvable from your end perhaps? We just use pip's --use-deprecated=legacy-resolver to get around this but we were curious to see if staying on torch 1.8.2 will cause some issues for this library.

Pretty neat package btw, thanks a lot for maintaining it ❤️
@finiteautomata
Copy link
Collaborator

@anthony2261 Thanks for letting me know that there were LTS versions of torch, I wasn't really aware of such distinction!

TBH, I'm not quite sure why we need 1.9.0 version. I will try to downgrade it and check if it still works. Perhaps it was added by accident when I migrated from pipenv to poetry. I leave this open for further updates on it

@finiteautomata
Copy link
Collaborator

Well, LTS support was deprecated, so we shouldn't care about this anymore

https://pytorch.org/blog/pytorch-enterprise-support-update/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@finiteautomata @anthony2261