Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
p
is a Serial over Bluetooth link, thenos.path.islink(p)
may take several seconds.In two of my Windows 10 computers following code used to take 5 seconds:
I found out that the delay was caused by
os.path.islink('COM5')
. COM5 is one of the "Bluetooth over serial" ports backed by LogiLink Bluetooth dongle.After my change it takes 0.01 seconds.
If I'm not mistaken, then
list_ports_windows
can't list symlinks anyway, so this time consuming check can be turned off for Windows.